[PATCH] D113472: [clang-tidy] Fix lint warning in ClangTidyDiagnosticConsumer.cpp (NFC)

Salman Javed via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 9 03:43:42 PST 2021


salman-javed-nz added a comment.

I suspect that ensuring that `NOLINT`s are within a comment could be a reasonably large code change. If it is to be robust with `/* multiline comments */`  and other shenanigans, then I would probably lean on the compiler to tell us what is and isn't a comment, instead of the simple text search approach we currently have.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113472/new/

https://reviews.llvm.org/D113472



More information about the cfe-commits mailing list