[PATCH] D113472: [clang-tidy] Fix lint warning in ClangTidyDiagnosticConsumer.cpp (NFC)
Carlos Galvez via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Nov 9 02:55:39 PST 2021
carlosgalvezp added a comment.
Hmm, this sounds a bit hacky. I noticed a similar pattern in tests. I think it deteriorates readability a bit.
Can we make the detection of the tag more robust? Right now we check if a line contains NOLINTBEGIN/END. Why not check if it contains "// NOLINTBEGIN"? (// as part of the line).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113472/new/
https://reviews.llvm.org/D113472
More information about the cfe-commits
mailing list