[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

Chuanqi Xu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 8 19:23:23 PST 2021


ChuanqiXu added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3445-3447
-  // -fmodules enables the use of precompiled modules (off by default).
-  // Users can pass -fno-cxx-modules to turn off modules support for
-  // C++/Objective-C++ programs.
----------------
>From our discussion, `fmodules` shouldn't be suppressed by `fno-cxx-modules`. And the tests shows that is wouldn't be a problem to relax this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113391/new/

https://reviews.llvm.org/D113391



More information about the cfe-commits mailing list