[PATCH] D113304: [NewPM] Only invalidate modified functions' analyses in CGSCC passes + turn on eagerly invalidate analyses
Arthur Eubanks via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 8 10:02:34 PST 2021
aeubanks added a comment.
In D113304#3112937 <https://reviews.llvm.org/D113304#3112937>, @nikic wrote:
> I don't think I fully understand the interaction this has with eager invalidation. I would have expected that if we eagerly invalidate, then this fine-grained invalidation wouldn't make much of a difference, because we invalidate anyway after processing a function.
if we've already calculated e.g. DT for all functions in an SCC prior to visiting the SCC, currently if an SCC pass changes any of the functions, we'd invalidate analyses for all the functions in the SCC, meaning function passes in the SCC adaptor would have to recalculate. but if we do this fine-grained invalidation we won't have to recalculate DT in the function passes for functions that weren't modified in the SCC pass
I'll add this to the description
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits