[PATCH] D113304: [NewPM] Only invalidate modified functions' analyses in CGSCC passes + turn on eagerly invalidate analyses

[Arthur Eubanks via Phabricator via cfe-commits]

aeubanks added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/FunctionAttrs.cpp:1845
+      if (auto *Call = dyn_cast<CallBase>(U))
+        FAM.invalidate(*Call->getParent()->getParent(), FuncPA);
+    }
----------------
nikic wrote:
> Do we need to worry about indirect references here, like a call through a bitcast? For the ArgPromotion case that's not possible, but I'm not so sure here.
I suppose it's possible for analyses to look at all references to other functions and look at attributes of those functions, but I can't really imagine that happening in practice. AFAICT everything that looks at function attributes only does so for direct calls.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113304/new/

https://reviews.llvm.org/D113304