[PATCH] D113269: [clang-move] Fix unit tests with forward slash as separator on windows

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 8 09:43:08 PST 2021


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from commenting nit.



================
Comment at: clang-tools-extra/unittests/clang-move/ClangMoveTests.cpp:235
 
- // std::string IncludeArg = Twine("-I" + WorkingDir;
+ // std::string IncludeArg = Twine("-I" + Dir;
   tooling::runToolOnCodeWithArgs(
----------------
Might as well remove this comment entirely? I don't think it adds any value, it looks like debug code that was left in by accident.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113269/new/

https://reviews.llvm.org/D113269



More information about the cfe-commits mailing list