[PATCH] D113201: [clang-tidy] Fix a crash in modernize-loop-convert around conversion operators

Bal√°zs Benics via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 8 06:13:48 PST 2021


steakhal accepted this revision.
steakhal added a comment.
This revision is now accepted and ready to land.

Looks great.



================
Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp:155
 
-/// Look through conversion/copy constructors to find the explicit
+/// Look through conversion/copy constructors and operators to find the explicit
 /// initialization expression, returning it is found.
----------------
I think it's called //conversion member functions//.


================
Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.h:278
 // General functions used by ForLoopIndexUseVisitor and LoopConvertCheck.
-const Expr *digThroughConstructors(const Expr *E);
+const Expr *digThroughConstructorsConversions(const Expr *E);
 bool areSameExpr(ASTContext *Context, const Expr *First, const Expr *Second);
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113201/new/

https://reviews.llvm.org/D113201



More information about the cfe-commits mailing list