[PATCH] D80804: [AMDGPU] Introduce Clang builtins to be mapped to AMDGCN atomic inc/dec intrinsics
Matt Arsenault via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 8 05:54:13 PST 2021
arsenm added inline comments.
================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14563
- if (isa<llvm::ConstantInt>(Order)) {
- int ord = cast<llvm::ConstantInt>(Order)->getZExtValue();
+ switch (BuiltinID) {
+ case AMDGPU::BI__builtin_amdgcn_atomic_inc32:
----------------
RKSimon wrote:
> @saiislam @arsenm Coverity is warning that the BI__builtin_amdgcn_fence (fallthrough case) is not handled meaning that BuiltinAtomicOp in uninitialized
Test is also missing for builtin_amdgcn_fence
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80804/new/
https://reviews.llvm.org/D80804
More information about the cfe-commits
mailing list