[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

Chuanqi Xu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 8 03:51:21 PST 2021


ChuanqiXu added a comment.

In D113391#3115080 <https://reviews.llvm.org/D113391#3115080>, @tschuett wrote:

> This sounds like an enum.
>
>   enum class ModuleKind {
>   C++20,
>   Clang,
>   Unsupported
>   }

In fact, there is another value `ModuleTS`. But it looks not bad. And the variable `CPlusPlusModules` and `ClangModules` comes from options directly (See Options.td for details). So it looks like we couldn't eliminate `CPlusPlusModules` and `ClangModules` after we introduce this enum. So the overall complexity didn't get decreased to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113391/new/

https://reviews.llvm.org/D113391



More information about the cfe-commits mailing list