[PATCH] D111264: Comment AST: Declare function pointer variables as functions
Dmitri Gribenko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 8 03:50:29 PST 2021
gribozavr2 accepted this revision.
gribozavr2 added a comment.
This revision is now accepted and ready to land.
I feel uneasy about claiming that variable decls of function type are FunctionKind for the purposes of comment parsing (even doing it for typedefs is questionable). It seems like a better way would be to make "is function like" an extra dimension that can be combined with any decl kind.
However since no tests break, it might be not an issue in practice.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits