[PATCH] D111190: Comment parsing: Complete list of Doxygen commands

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 8 02:34:14 PST 2021


gribozavr2 accepted this revision.
gribozavr2 added a comment.
This revision is now accepted and ready to land.

Sorry for the delayed response! LGTM modulo the unit test comment. Please let me know if you don't have commit access and you need me to push on your behalf.



================
Comment at: clang/lib/AST/CommentLexer.cpp:399
+        if (C == '$' || C == '(' || C == ')' || C == '[' || C == ']' ||
+            C == '{' || C == '}') {
           TokenPtr++;
----------------
Please add adjust the unit test: clang/unittests/AST/CommentLexer.cpp (`TEST_F(CommentLexerTest, VerbatimBlock9)`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111190/new/

https://reviews.llvm.org/D111190



More information about the cfe-commits mailing list