[PATCH] D113352: [clang] Run LLVM Verifier in modes without CodeGen too

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Nov 6 23:01:22 PDT 2021


rjmccall added a comment.

Seems like a good idea to me.  Minor request; otherwise, feel free to commit.



================
Comment at: clang/lib/CodeGen/BackendUtil.cpp:1438
+    // Add it here so that it runs prior to the BC/LL emission pass
+    MPM.addPass(VerifierPass());
+
----------------
This comment should be more like what you've got in your patch summary, e.g. "Add a verifier pass if requested.  We don't have to do this if the action requires code generation because there will already be a verifier pass in the code-generation pipeline."  (And it should go above the `if`.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113352/new/

https://reviews.llvm.org/D113352



More information about the cfe-commits mailing list