[PATCH] D113261: [analyzer][solver] Remove reference to RangedConstraintManager

Balázs Benics via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 5 09:37:46 PDT 2021


steakhal accepted this revision.
steakhal added a comment.
This revision is now accepted and ready to land.

Yey, it looks good.



================
Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1608
   LLVM_NODISCARD static ProgramStateRef
-  assign(ProgramStateRef State, RangeConstraintManager &RCM,
-         SValBuilder &Builder, RangeSet::Factory &F, ClassOrSymbol CoS,
-         RangeSet NewConstraint) {
+  assign(ProgramStateRef State, SValBuilder &Builder, RangeSet::Factory &F,
+         ClassOrSymbol CoS, RangeSet NewConstraint) {
----------------
It seems odd, that sometimes it's called `Builder` and more frequently simply `SVB`.
We should consider consolidating this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113261/new/

https://reviews.llvm.org/D113261



More information about the cfe-commits mailing list