[PATCH] D113246: [clang][tests] Fix expected output of plugin-attribute test

Timm Bäder via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 5 01:16:49 PDT 2021


tbaeder created this revision.
tbaeder added a reviewer: psionic12.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

The output contains "const char[11]", not "const char [11]".

I don't think this test is being run in CI at all because it requires both examples and plugins.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D113246

Files:
  clang/test/Frontend/plugin-attribute.cpp


Index: clang/test/Frontend/plugin-attribute.cpp
===================================================================
--- clang/test/Frontend/plugin-attribute.cpp
+++ clang/test/Frontend/plugin-attribute.cpp
@@ -9,7 +9,7 @@
 [[plugin::example]] void fn1c() {}
 void fn2() __attribute__((example("somestring", 1, 2.0))) {}
 // CHECK-COUNT-4: -AnnotateAttr 0x{{[0-9a-z]+}} {{<col:[0-9]+(, col:[0-9]+)?>}} "example"
-// CHECK: -StringLiteral 0x{{[0-9a-z]+}} {{<col:[0-9]+(, col:[0-9]+)?>}} 'const char [{{[0-9]+}}]' lvalue "somestring"
+// CHECK: -StringLiteral 0x{{[0-9a-z]+}} {{<col:[0-9]+(, col:[0-9]+)?>}} 'const char[{{[0-9]+}}]' lvalue "somestring"
 // CHECK: -IntegerLiteral 0x{{[0-9a-z]+}} {{<col:[0-9]+(, col:[0-9]+)?>}} 'int' 1
 // CHECK: -FloatingLiteral 0x{{[0-9a-z]+}} {{<col:[0-9]+(, col:[0-9]+)?>}} 'double' 2.000000e+00
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113246.384979.patch
Type: text/x-patch
Size: 833 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20211105/950ccc9c/attachment.bin>


More information about the cfe-commits mailing list