[PATCH] D111654: [analyzer] Retrieve a value from list initialization of multi-dimensional array declaration.

[Balázs Benics via Phabricator via cfe-commits]

steakhal added a comment.

In D111654#3109585 <https://reviews.llvm.org/D111654#3109585>, @ASDenysPetrov wrote:

> @steakhal Thank you for your suggestion. I'll make corresponding changes.
>
>> I'm still worried about the fact that you assume that there is a correspondence between `ElementRegions` and `InitListExprs`.
>> I cannot see why this assumption holds, since reinterpret casts might introduce `ElementRegions` which could mess with this assumption.
>
> Currently in practice `ElementRegions` for array element access expression look like `InitListExprs` structure. But you are right about mess with different casts. That's why I have //FIXME's//  in `glob_ptr_index2` and `glob_invalid_index6`.
> Right now I'm working on fixing this stuff. I'm gonna refactor `StoreManager::castRegion` in a part of `ElementRegions` to distinguish between array indirections and casts.

Awesome! Let's get the minor nits addressed and land it.
Thank you for working on this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111654/new/

https://reviews.llvm.org/D111654