[PATCH] D113211: [NFC][clang] Inclusive terms: replace uses of blacklist in clang/test/

[Jan Korous via Phabricator via cfe-commits]

jkorous requested changes to this revision.
jkorous added a comment.
This revision now requires changes to proceed.

Hi! Thank you for the clean-up :)

I feel there might be a bit of work still left. While renaming filenames and function names should be mostly inconsequential renaming command line options and sanitizer ignorelist content (and by that changing the syntax) most likely need accompanying changes in clang itself.

I noticed you have at least one other similar patch but I don't see the changes I'd expect there - please let me know if I'm just missing something!

Do the tests actually pass with this patch?



================
Comment at: clang/test/CodeGen/address-safety-attr.cpp:9
 
-// RUN: echo "fun:*BlacklistedFunction*" > %t.func.blacklist
-// RUN: %clang_cc1 -std=c++11 -triple x86_64-apple-darwin -disable-O0-optnone -emit-llvm -o - %s -include %t.extra-source.cpp -fsanitize=address -fsanitize-blacklist=%t.func.blacklist | FileCheck -check-prefix=BLFUNC %s
+// RUN: echo "fun:*IgnorelistedFunction*" > %t.func.ignorelist
+// RUN: %clang_cc1 -std=c++11 -triple x86_64-apple-darwin -disable-O0-optnone -emit-llvm -o - %s -include %t.extra-source.cpp -fsanitize=address -fsanitize-ignorelist=%t.func.ignorelist | FileCheck -check-prefix=BLFUNC %s
----------------
Shouldn't we teach ASan about the new syntax of ignorelist as well `fun:*IgnorelistedFunction*`?


================
Comment at: clang/test/CodeGen/address-safety-attr.cpp:10
+// RUN: echo "fun:*IgnorelistedFunction*" > %t.func.ignorelist
+// RUN: %clang_cc1 -std=c++11 -triple x86_64-apple-darwin -disable-O0-optnone -emit-llvm -o - %s -include %t.extra-source.cpp -fsanitize=address -fsanitize-ignorelist=%t.func.ignorelist | FileCheck -check-prefix=BLFUNC %s
 
----------------
Shouldn't the change of the option name to `-fsanitize-ignorelist` in tests be accompanied with analogous change in driver and/or cc1 options definition?


================
Comment at: clang/test/CodeGenCXX/cfi-ignorelist.cpp:3
 
-// Check that blacklisting cfi and cfi-vcall work correctly
+// Check that ignore listing cfi and cfi-vcall work correctly
 // RUN: echo "[cfi-vcall]" > %t.vcall.txt
----------------
We should use the verb "to ignorelist smth" (without the space) consistently.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113211/new/

https://reviews.llvm.org/D113211