[PATCH] D112732: [ASan] Process functions in Asan module pass

[Vitaly Buka via Phabricator via cfe-commits]

vitalybuka added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1289
+  }
+  Modified |= ModuleSanitizer.instrumentModule(M);
+  if (Modified)
----------------
vitalybuka wrote:
> kstoimenov wrote:
> > At first I had module sanitizer run first, but some tests failed. Is it possible that the function pass has some side effects, which are used by the module pass? 
> That's OK.
> 
> NewPMDriver.cpp was wrong, BackendUtil.cpp was wrong
> 
> if we put module in-front of function  the following with disable globals instrumentation:
> ```
>  if (G && (!ClInitializers || GlobalIsLinkerInitialized(G)) &&
>         isSafeAccess(ObjSizeVis, Addr, O.TypeSize)) {
> ```
> 
Fixing typo in the comment.
>> NewPMDriver.cpp was wrong, BackendUtil.cpp was wrong
NewPMDriver.cpp was correct, BackendUtil.cpp was wrong


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112732/new/

https://reviews.llvm.org/D112732