[PATCH] D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates.

Michael Liao via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 4 07:49:06 PDT 2021


hliao marked an inline comment as done.
hliao added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp:196
   void inferAddressSpaces(ArrayRef<WeakTrackingVH> Postorder,
-                          ValueToAddrSpaceMapTy *InferredAddrSpace) const;
+                          ValueToAddrSpaceMapTy *InferredAddrSpace,
+                          PredicatedAddrSpaceMapTy &PredicatedAS) const;
----------------
tra wrote:
> hliao wrote:
> > tra wrote:
> > > I think this could've been a reference, too.
> > yeah, but we should address that in another change.
> You're already changing function signatures.It would be reasonable to incorporate this cleanup, too.
revised in the latest patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112041/new/

https://reviews.llvm.org/D112041



More information about the cfe-commits mailing list