[PATCH] D112431: [ARM][clang] Define feature test macro for the PACBTI-M extension

Momchil Velikov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 4 07:28:15 PDT 2021


chill added inline comments.


================
Comment at: clang/lib/Basic/Targets/ARM.cpp:897
+    Builder.defineMacro("__ARM_FEATURE_PAUTH", "1");
+    Builder.defineMacro("__ARM_FEATURE_BTI", "1");
+  }
----------------
miyuki wrote:
> Since we decided to have two separate flags, I think this line should be in a separate if statement: `if (HasBTI)`.
Agree. If this ever changes, we'd have to modify only  around lines 550.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112431/new/

https://reviews.llvm.org/D112431



More information about the cfe-commits mailing list