[PATCH] D112926: run-clang-tidy.py analyze unique files only

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 4 06:54:53 PDT 2021


lebedev.ri added a comment.

In D112926#3108745 <https://reviews.llvm.org/D112926#3108745>, @kuhar wrote:

> I think this change is fine.



> One could argue that having multiple files is an issue with tooling/build system in the first place,

No, why would that be a bug in itself? It may be a bug when they have the exact same externally-observable side-effects
(i.e. the output filename and/or the other options passed to the compiler).
The usual case where that could happen is when the source file has conditionally-compiled blocks,
and is compiled multiple times with different defines to produce different object files.

> and we could consider printing a warning instead of silently fixing it up, but I don't think there's that much to gain from being pedantic here.




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112926/new/

https://reviews.llvm.org/D112926



More information about the cfe-commits mailing list