[PATCH] D112926: run-clang-tidy.py analyze unique files only

Serikzhan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 4 05:04:00 PDT 2021


serkazi added a comment.

In D112926#3108140 <https://reviews.llvm.org/D112926#3108140>, @salman-javed-nz wrote:

> It looks good to me. I don't have any more comments to add - it is a very small code change after all.
> I have commit access and am happy to commit it on your behalf.
>
> However, this would be my first time as a reviewer, and I don't want to be presumptuous and approve this before someone with more experience in the area has had a chance to look at it.
>
> The rule of thumb is to wait a week before sending a ping. Then we'll see what we can do to get this through.

Thank you. I leave it with you, then. And if in a week there is no response, I'll ping, as you've kindly suggested.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112926/new/

https://reviews.llvm.org/D112926



More information about the cfe-commits mailing list