[PATCH] D113096: [X86][MS-InlineAsm] Add constraint *m for memory access w/ global var

Kan Shengchen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 3 16:59:21 PDT 2021


skan marked 2 inline comments as done.
skan added inline comments.


================
Comment at: llvm/test/CodeGen/X86/ms-inline-asm-array.ll:15-22
+!llvm.module.flags = !{!0, !1, !2}
+!llvm.ident = !{!3}
+
+!0 = !{i32 1, !"wchar_size", i32 4}
+!1 = !{i32 7, !"uwtable", i32 1}
+!2 = !{i32 7, !"frame-pointer", i32 2}
+!3 = !{!"clang"}
----------------
pengfei wrote:
> These seem unnecessary.
This is necessary b/c we need to check the inline-asm IR can be rerwritten to correct assmbly after constraint "*m" is added.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113096/new/

https://reviews.llvm.org/D113096



More information about the cfe-commits mailing list