[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

Christian Kandeler via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 3 09:19:15 PDT 2021


ckandeler added inline comments.


================
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:9619
+    const bool ExtensionlessHeaders = IsSystem || isQt
+        || Dir.endswith(".framework/Headers");
     std::error_code EC;
----------------
I'm just noticing that this is often a symlink into a versioned directory (e.g. xxx.framework/Version/5/Headers). The include paths are not canonicalized, I hope?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112996/new/

https://reviews.llvm.org/D112996



More information about the cfe-commits mailing list