[PATCH] D113043: "[mlir][sparse]Rename SparseUtils.cpp library to SparseTensorUtils.cpp"
Akot Harriet Peace via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Nov 2 13:24:12 PDT 2021
HarrietAkot added a comment.
In D113043#3103979 <https://reviews.llvm.org/D113043#3103979>, @aartbik wrote:
> Did you see my comment on clang/docs/tools/clang-formatted-files.txt?
> You will need to update that file too (SparseUtils.cpp -> SparseTensorUtils.cpp)
>
> after that this revision is good to go!
> (do you have submit rights, or do you want me to do that, once we are there?)
I have made the changes to the clang-formatted-files.txt. Kindly submit this revision for me. Thank you
================
Comment at: mlir/lib/ExecutionEngine/SparseTensorUtils.cpp:1
-//===- SparseUtils.cpp - Sparse Utils for MLIR execution ------------------===//
+//===- SparseTensorUtils.cpp - Sparse Utils for MLIR execution ------------===//
//
----------------
aartbik wrote:
> While you are here, how about changing the contents to
>
> //===- SparseTensorUtils.cpp - Sparse tensor utils for MLIR execution
>
> to make it more consistent with the name
Done :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113043/new/
https://reviews.llvm.org/D113043
More information about the cfe-commits
mailing list