[PATCH] D112001: [Clang] Add min/max reduction builtins.

Florian Hahn via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 1 14:53:00 PDT 2021


fhahn updated this revision to Diff 383900.
fhahn added a comment.

In D112001#3099965 <https://reviews.llvm.org/D112001#3099965>, @aaron.ballman wrote:

> Precommit CI looks to be failing.
>
>   /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/builtins-reduction-math.c:13:9: error: initializing 'float' with an expression of incompatible type 'float4' (vector of 4 'float' values)
>   
>     float r1 = __builtin_reduce_max(vf1);

The last version of the patch did not correctly set the return type to the element type. That should be fixed now!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112001/new/

https://reviews.llvm.org/D112001

Files:
  clang/include/clang/Basic/Builtins.def
  clang/include/clang/Basic/DiagnosticSemaKinds.td
  clang/include/clang/Sema/Sema.h
  clang/lib/CodeGen/CGBuiltin.cpp
  clang/lib/Sema/SemaChecking.cpp
  clang/test/CodeGen/builtins-reduction-math.c
  clang/test/Sema/builtins-reduction-math.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D112001.383900.patch
Type: text/x-patch
Size: 9683 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20211101/185d6f31/attachment-0001.bin>


More information about the cfe-commits mailing list