[PATCH] D112864: [clang-tidy] Fix lint warnings in clang-tidy source code (NFC)

Sat Oct 30 21:09:28 PDT 2021

salman-javed-nz added a comment.

In D112864#3098351 <https://reviews.llvm.org/D112864#3098351>, @carlosgalvezp wrote:

> Looks great, thanks for fixing! I'm surprised we don't have a CI bot running these checks post-merge?

You would think so, but it looks like automatic checking during CI was disabled in this commit:
https://github.com/google/llvm-premerge-checks/commit/b69eb6f3647ecb67ff85e551323b3445acde684b

Anyway, even if you run clang-tidy manually, you could miss many issues. A number of warnings are in the header files, and they only get revealed if you set `--header-filter` properly to look at them.

I will leave this review open for a few days in case other people have comments to add. This patch isn't urgent.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112864/new/

https://reviews.llvm.org/D112864