[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

[Elizabeth Andrews via Phabricator via cfe-commits]

eandrews added a comment.

In D109950#3097161 <https://reviews.llvm.org/D109950#3097161>, @rjmccall wrote:

> Oh, yes, I think this should be preserving the old logic there and just adding a new clause for explicit requests for ibm128, right?

I think the old logic should be preserved yes. However, I'm not sure if this patch exposes an existing bug. LongDoubleFormat here is llvm::semX87DoubleExtended.

In APFloat.cpp, it is defined as -

  static const fltSemantics semX87DoubleExtended = {16383, -16382, 64, 80};

i.e. 80 bit size. Is this the right format for complex type specified using mode 'TC'? I am not very familiar with floating point semantics, so I thought I would ask.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109950/new/

https://reviews.llvm.org/D109950