[PATCH] D112101: [AST] Fix the EndLoc calculation for ObjCObjectPointer

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 29 12:07:51 PDT 2021


rsmith added a comment.

I think this is still not quite right: if the `ObjCObjectPointerType` has a valid star location, we should use that. We should only be falling back on the inner location's end when there is no star. For example:

  @interface X @end;
  using ObjectPointer = X*;

... should have an end loc that points at the `*`, not the `X`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112101/new/

https://reviews.llvm.org/D112101



More information about the cfe-commits mailing list