[PATCH] D112791: [IR] Merge createReplacementInstr into ConstantExpr::getAsInstruction
Yaxun Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Oct 29 06:47:54 PDT 2021
yaxunl added inline comments.
================
Comment at: llvm/include/llvm/IR/Constants.h:1317
/// would make it harder to remove ConstantExprs altogether.
- Instruction *getAsInstruction() const;
+ Instruction *getAsInstruction(Instruction *InsertBefore = nullptr) const;
----------------
Can you add a comment about the insertion location when 'InsertBefore' is nullptr? Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112791/new/
https://reviews.llvm.org/D112791
More information about the cfe-commits
mailing list