[PATCH] D112059: Fix inline builtin handling in case of redefinition

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 29 04:08:34 PDT 2021


aaron.ballman accepted this revision.
aaron.ballman added a comment.

LGTM aside from a formatting nit. I don't think the precommit CI failures are related to your patch from what I was seeing, but may be worth keeping an eye on once you land just in case.



================
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:1323
+    else {
+      for(const FunctionDecl* PD = FD->getPreviousDecl(); PD; PD = PD->getPreviousDecl()) {
+        if(LLVM_UNLIKELY(PD->isInlineBuiltinDeclaration())) {
----------------
Please fix the formatting.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112059/new/

https://reviews.llvm.org/D112059



More information about the cfe-commits mailing list