[PATCH] D112783: [clangd] Track performance of IncludeCleaner

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:275
 std::vector<const Inclusion *> computeUnusedIncludes(ParsedAST &AST) {
+  trace::Span Tracer("IncludeCleaner::computeUnusedIncludes");
   const auto &SM = AST.getSourceManager();
----------------
this doesn't look interesting on its own, as it doesn't perform much magic. maybe just drop?


================
Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:284
 
 std::vector<Diag> issueUnusedIncludesDiagnostics(ParsedAST &AST,
                                                  llvm::StringRef Code) {
----------------
i believe this is the function that deserves a trace the most, as it is alive throughout the whole interaction and will reflect full latency.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112783/new/

https://reviews.llvm.org/D112783