[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

Thu Oct 28 09:53:52 PDT 2021

kstoimenov added inline comments.

================
Comment at: llvm/include/llvm/Analysis/StackSafetyAnalysis.h:93
+  bool invalidate(Module &, const PreservedAnalyses &,
+                  ModuleAnalysisManager::Invalidator &) {
+    return false;
----------------
eugenis wrote:
> vitalybuka wrote:
> > vitalybuka wrote:
> > > we still can't do that, some passes can make results irrelevant
> > Looks like only immutable analysis can be used through proxy, and this analysis cannot be immutable.
> > Maybe we have to convert Asan into ModulePass, like HWAsan.
> > Any other ideas? @eugenis @pcc @morehouse 
> Is the problem here that an invalidated analysis needs to be rerun, and the module-to-function proxy does not know how to do that?
> 
> TBH, I'm not sure how big the performance benefits of a function pass are. With the amount of time we've sunk in working around function pass requirements and I'd say just go for it.
> 
See https://reviews.llvm.org/D112732. I changed it for the new pass manager only. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112098/new/

https://reviews.llvm.org/D112098