[PATCH] D112712: [clangd] SelectionTree should prefer lexical declcontext

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet marked 3 inline comments as done.
kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:751
+  {
+    auto ST = SelectionTree::createRight(AST.getASTContext(), AST.getTokens(),
+                                         Test.point("2"), Test.point("2"));
----------------
sammccall wrote:
> I'd probably use makeSelectionTree(Test.code(), AST) for brevity and only test the #2 case, but up to you
i'd rather keep both, just to make sure we are not accidentally regressing the other case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112712/new/

https://reviews.llvm.org/D112712