[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

Balázs Benics via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 28 05:20:27 PDT 2021


steakhal accepted this revision.
steakhal added a comment.
This revision is now accepted and ready to land.

There is no need to do anything with this. You can commit as-is.
I've done it myself, and it seems like your patch only turns `TRUE` for the cases where it was `UNKNOWN` or `FALSE` previously.
So these test cases were changed by your test, and the rest of them were preserved in your patch:
`glob_array_index5()`, `glob_ptr_index3()`, `glob_array_index6()`, `glob_ptr_index5()`, `glob_ptr_index6()`, `glob_ptr_index7()`

Next time I would rather have two patches, one of which adds tests to document the existing behavior and a follow-up changing the behavior.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107339/new/

https://reviews.llvm.org/D107339



More information about the cfe-commits mailing list