[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

Adrian Vogelsgesang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 28 04:14:00 PDT 2021


avogelsgesang marked 2 inline comments as done.
avogelsgesang added inline comments.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:341-343
+   `cert-exp42-c <cert-exp42-c.html>`_, `bugprone-suspicious-memory-comparison <bugprone-suspicious-memory-comparison.html>`_,
    `cert-fio38-c <cert-fio38-c.html>`_, `misc-non-copyable-objects <misc-non-copyable-objects.html>`_,
+   `cert-flp37-c <cert-flp37-c.html>`_, `bugprone-suspicious-memory-comparison <bugprone-suspicious-memory-comparison.html>`_,
----------------
avogelsgesang wrote:
> whisperity wrote:
> > These are unrelated changes coming from a lack of rebase or a too eager diff.
> those changes were added by `add_new_check.py`.
> I guess `add_new_check.py` recreates the complete `list.rst` file, and the previously checked in `list.rst` was not in sync with the remaining files...
> 
> Do you want me to remove those changes from this commit?
I removed the other changes from this commit


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112646/new/

https://reviews.llvm.org/D112646



More information about the cfe-commits mailing list