[PATCH] D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy.

[Craig Topper via Phabricator via cfe-commits]

craig.topper added a comment.

I think the concept seems good to me. I'd like @aaron.ballman to review the attribute code.



================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18610
   unsigned NF = 1;
   constexpr unsigned TAIL_UNDISTURBED = 0;
+  constexpr unsigned TAIL_AGNOSTIC = 0b01;
----------------
Is constant still used?


================
Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:883
+
+  const char *policySuffix[] = {"tumu", "tamu", "tuma", "tama"};
+
----------------
Capitalize `policySuffix` and make it

`static const char *const PolicySuffix[]`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112534/new/

https://reviews.llvm.org/D112534