[PATCH] D112645: [OpenMP] Fix: opposite attributes could be set by -fno-inline

Igor Kirillov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 27 11:55:35 PDT 2021


igor.kirillov added inline comments.


================
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5370
   if (CGM.getCodeGenOpts().OptimizationLevel != 0)
     Fn->addFnAttr(llvm::Attribute::AlwaysInline);
   return Fn;
----------------
I noticed that here we set this attribute on the same function that is created by `emitOutlinedFunctionPrologue` but there AlwaysInline attribute is guaranteed to be set under same condition. So I suppose we could remove this piece of code?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112645/new/

https://reviews.llvm.org/D112645



More information about the cfe-commits mailing list