[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg
gehry via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 27 06:01:30 PDT 2021
Sockke marked 2 inline comments as done.
Sockke added a comment.
In D107450#3087103 <https://reviews.llvm.org/D107450#3087103>, @whisperity wrote:
> I think this is becoming okay and looks safe enough. I can't really grasp what `HasCheckedMoveSet` means, and how it synergises with storing `CallExpr`s so maybe a better name should be added. Do you mean `AlreadyCheckedMoves`? When is it possible that the same `CallExpr` of `std::move` will be matched multiple times?
Yes, you're right!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107450/new/
https://reviews.llvm.org/D107450
More information about the cfe-commits
mailing list