[PATCH] D109632: [clang] de-duplicate methods from AST files

[Volodymyr Sapsai via Phabricator via cfe-commits]

vsapsai added a comment.

In D109632#3086044 <https://reviews.llvm.org/D109632#3086044>, @rmaz wrote:

> @vsapsai i'll abandon this diff then, thanks for your extensive feedback on the approach. Is D110123 <https://reviews.llvm.org/D110123> shippable already, or are there some more corner cases to cover?

Code-wise I'm not aware of any remaining issues. Still need to update the commit message and to re-run the  clang test suite. But you can totally use the patch for testing. I plan to update D110123 <https://reviews.llvm.org/D110123> for the review today/tomorrow.

In my limited internal testing I've seen a single extra warning due to `[(id)specificObject commonMethodName]`. I've discussed it with other Objective-C developers and the consensus is that with calling methods on `id` you cannot predict which exactly method signature will be selected and the recommended solution to cast `specificObject` to correct type with the known method signature. It might be worth running a more extensive test and make sure there are no unintended consequences. That will take me around a week or slightly more.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109632/new/

https://reviews.llvm.org/D109632