[PATCH] D112532: [Matrix] Replace some err kinds with err_builtin_invalid_arg_type. (NFC)

[Florian Hahn via Phabricator via cfe-commits]

fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:16582
+    Diag(Matrix->getBeginLoc(), diag::err_builtin_invalid_arg_type)
+        << 1 << 1 << Matrix->getType();
     return ExprError();
----------------
erichkeane wrote:
> 1 nit: On the 'select' lines, please put a /**/ comment next to the integer to explain what it is.  If they were all closer to eachother, I'd suggest doing an enum for them, but the comment should be good enough.
done, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112532/new/

https://reviews.llvm.org/D112532