[PATCH] D112565: [clangd] Add integration test for crash handling

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 26 11:23:47 PDT 2021


sammccall created this revision.
sammccall added reviewers: kadircet, 0x1eaf.
Herald added subscribers: usaxena95, arphaman, javed.absar.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.

This replaces the test removed in 51be7061d025139ba66869d5d99c7157a3ae9edd <https://reviews.llvm.org/rG51be7061d025139ba66869d5d99c7157a3ae9edd>
It is more principled and tests more critical cases: a crash while parsing.

We need two pieces of plumbing:

- a way to re-enable the crashing #pragmas via a flag, to test parse crashes
- a bit of reshuffling around ASTWorker execution so that we set up the crash handler in both sync/async modes. Sync mode is useful for debugging, so I tested both.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D112565

Files:
  clang-tools-extra/clangd/Compiler.cpp
  clang-tools-extra/clangd/Compiler.h
  clang-tools-extra/clangd/TUScheduler.cpp
  clang-tools-extra/clangd/test/crash-parse.test
  clang-tools-extra/clangd/test/crash-preamble.test
  clang-tools-extra/clangd/tool/ClangdMain.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D112565.382407.patch
Type: text/x-patch
Size: 7585 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20211026/b2cbb880/attachment.bin>


More information about the cfe-commits mailing list