[PATCH] D112481: [Sema] fix nondeterminism in ASTContext::getDeducedTemplateSpecializationType

[Igor Sugak via Phabricator via cfe-commits]

sugak added inline comments.


================
Comment at: clang/lib/AST/ASTContext.cpp:5640
+  DeducedTemplateSpecializationType::Profile(
+      ID, Template, DeducedType, IsDependent || Template.isDependent());
   if (DeducedTemplateSpecializationType *DTST =
----------------
bruno wrote:
> Should this be done in the implementation (like done for the ctor)?
> ```
> static void Profile(llvm::FoldingSetNodeID &ID, TemplateName Template,
>                       QualType Deduced, bool IsDependent) {
>     Template.Profile(ID);
>     ID.AddPointer(Deduced.getAsOpaquePtr());
>     ID.AddBoolean(IsDependent || Template.isDependent());
>   }
> ```
Thanks for the suggestion! Indeed that look better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112481/new/

https://reviews.llvm.org/D112481