[PATCH] D112532: [Matrix] Replace some err kinds with err_builtin_invalid_arg_type. (NFC)

Florian Hahn via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 26 09:31:20 PDT 2021


fhahn added inline comments.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:16654
+    Diag(PtrExpr->getBeginLoc(), diag::err_builtin_invalid_arg_type)
+        << PtrArgIdx + 1 << "pointer to a valid matrix element type"
+        << PtrExpr->getType();
----------------
erichkeane wrote:
> Can you make these be a "select" instead?  It makes it really difficult to localize if we do this.
done, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112532/new/

https://reviews.llvm.org/D112532



More information about the cfe-commits mailing list