[PATCH] D109506: [clangd] Print current request context along with the stack trace

Tue Oct 26 05:19:52 PDT 2021

0x1eaf added a comment.

I think this should work-around end-to-end test failure on Windows:

  diff --git a/clang-tools-extra/clangd/test/crash.test b/clang-tools-extra/clangd/test/crash.test
  index 1197e1ab07c3..68ef54808f09 100644
  --- a/clang-tools-extra/clangd/test/crash.test
  +++ b/clang-tools-extra/clangd/test/crash.test
  @@ -1,3 +1,4 @@
  +# REQUIRES: shell
   # Overflow the recursive json parser, prevent `yes` error due to broken pipe and `clangd` SIGSEGV from being treated as a failure.
   # RUN: (yes '[' || :) | head -n 50000 | (clangd --input-style=delimited 2>&1 || :) | FileCheck %s
   #      CHECK: Signalled while processing message:

Alternatively, the test can be completely disabled for the time being.

I don't have commit access, should I create a new revision for review with the test change?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109506/new/

https://reviews.llvm.org/D109506