[PATCH] D112353: [bazel] fixes for windows build

[Yuanfang Chen via Phabricator via cfe-commits]

ychen added inline comments.


================
Comment at: utils/bazel/llvm-project-overlay/llvm/config.bzl:63
     # MSVC specific
-    "stricmp=_stricmp",
-    "strdup=_strdup",
+    #"stricmp=_stricmp",
+    #"strdup=_strdup",
----------------
GMNGeoffrey wrote:
> Just commenting these out isn't right. I believe you're likely hitting the same issue fixed in https://reviews.llvm.org/D112399 with macro redefines
Thanks for the link. Yeah, I wasn't sure about this part.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112353/new/

https://reviews.llvm.org/D112353