[PATCH] D112334: [clang-tidy] Suppress readability-static-access-through-instance for CUDA built-in variables

Mon Oct 25 12:07:31 PDT 2021

aaron.ballman accepted this revision.
aaron.ballman added a comment.

In D112334#3085119 <https://reviews.llvm.org/D112334#3085119>, @tra wrote:

> Is there a way to annotate the builtin vars in the header to let clang-tidy know explicitly that the code must be handled in a special way? That would avoid the guesswork.

Hmmm, there's https://github.com/llvm/llvm-project/commit/e09107ab80dced55414fa458cf78e6cdfe90da6e but that's for identifying builtin functions, not builtin types. I don't think we have an attribute for identifying builtin type declarations. It might be worthwhile for someone to explore whether it would make sense for `BuiltinAttr` to be used here or not, but that might be a heavy lift to make this clang-tidy check a bit more robust.

Patch LGTM again. :-)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112334/new/

https://reviews.llvm.org/D112334