[PATCH] D109506: [clangd] Print current request context along with the stack trace

Mon Oct 25 08:30:41 PDT 2021

sammccall added a comment.

In D109506#3059313 <https://reviews.llvm.org/D109506#3059313>, @0x1eaf wrote:

> I've instrumented preamble building, but haven't instrumented background indexing which is outside of `TUScheduler.cpp` and would require exposing `crashDump*` helpers and preferably moving them out of `TUScheduler.cpp`. And I think it might be easier to review it separately.

Sounds good!

> Speaking of the helpers, where would you prefer those to be: a new file+header under clangd/support, or in some existing place?

I think it's too concrete/specific to live in support.
There's no perfect place, maybe Compiler.h along with the definition of ParseInputs isn't so bad? That file is kind of a random assortment of low-level stuff anyway.

In D109506#3084550 <https://reviews.llvm.org/D109506#3084550>, @0x1eaf wrote:

> Are there any blockers to landing this?

Nope, just my kids have been sick and I've been losing track of things left and right.
Sorry about that, will land this now!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109506/new/

https://reviews.llvm.org/D109506