[PATCH] D112413: [X86] Add -mskip-rax-setup support to align with GCC

Phoebe Wang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 25 07:49:40 PDT 2021


pengfei added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:99
+    cl::desc("Skips setting up the RAX register when SSE is disabled and there "
+             "are no variable arguments passed in vector registers."),
+    cl::Hidden);
----------------
joerg wrote:
> The description needs some further clarification. It should likely be "can be passed" otherwise it begs the question of when the conditional statement is false.
Good suggestion. Done, thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112413/new/

https://reviews.llvm.org/D112413



More information about the cfe-commits mailing list