[PATCH] D111642: [Analyzer][solver] Simplification: reorganize equalities with adjustment

[Balázs Benics via Phabricator via cfe-commits]

steakhal accepted this revision.
steakhal added a comment.
This revision is now accepted and ready to land.

Awesome!
So clean, and I also like the tests.
Good job.



================
Comment at: clang/test/Analysis/solver-sym-simplification-adjustment.c:58
+  if (b != 1) {       // b == 1  --> c + 1 == 0 --> c == -1 contradiction
+    clang_analyzer_eval(b == 0);  // expected-warning{{TRUE}}
+    // Keep the symbols and the constraints! alive.
----------------
Please assert `clang_analyzer_eval(c == 0)` as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111642/new/

https://reviews.llvm.org/D111642