[PATCH] D111992: [MLIR][OpenMP] Added omp.atomic.read and omp.atomic.write

Peixin Qiao via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Oct 24 18:40:28 PDT 2021


peixin added inline comments.


================
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5993
   case OMPC_adjust_args:
+  case OMPC_memory_order:
     llvm_unreachable("Clause is not allowed in 'omp atomic'.");
----------------
peixin wrote:
> The memory_order clause in clang side is not handled in this patch. Maybe leaving the error is better since users will know it is not supported yet in clang.
> The memory_order clause in clang side is not handled in this patch. Maybe leaving the error is better since users will know it is not supported yet in clang.

Sorry. Please ignore this comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111992/new/

https://reviews.llvm.org/D111992



More information about the cfe-commits mailing list